perf(size): Remove per-binary full GC - #676
Merged
Merged
Conversation
Allow Python's normal collector policy to avoid repeated full-heap scans as binary analysis results accumulate.
Contributor
📲 Install BuildsiOS
Android
|
Contributor
Size Analysis1 component analyzed, 1 component processing iOS Builds
Android Builds
|
jamieQ
marked this pull request as ready for review
September 10, 2026 14:45
trevor-e
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The explicit python gc collection appears to scale poorly when processing apps with many binaries. I tested against an app with ~300 binaries, and the gc.collect() duration kept increasing over time taking up meaningful amounts of CPU time. This was particularly noticeable prior to allowing concurrent binary processing, as the garbage collection pauses in some cases could end up taking nearly half the overall binary analysis time. Even after the concurrent binary analysis processing change, this change still appeared to reduce overall wall time a bit and reduce CPU use without causing a meaningful regression in peak memory use.
The theory about the mechanism is that the heap keeps growing as we process lots of binaries (which is unavoidable to some extent though we're not currently trying very hard to mitigate that I don't think), and the gc scans therefore take longer over time.